search

Rudokhvist / ASF-STM

ASF bot list trade matcher
Apache License 2.0
24 stars 2 forks source link

Transfer data about a match from badges page to trade offer page via localStorage. Closes #20, #21 #23

Closed Rudokhvist closed 8 months ago

Rudokhvist commented 10 months ago

Current implementation sends data about matching cards to trade window via URL parameters. When there is a lot of items in one match it causes URL to be longer than limit allowed by browser and causes error. This PR moves this data transfer from URL parameters to localStorage, this should solve issue with big trades.

Additionally, I changed calls to element.Remove() into element.parentNode.removeChild(element), this should improve compatibility with third-party scripts that use outdated jQuery versions.

@EvE-player if you have time and are willing to help - get new version from https://github.com/Rudokhvist/ASF-STM/raw/tradeparams/ASF-STM.user.js and test it. Any feedback is appreciated.

EvE-Player commented 10 months ago

Hello @Rudokhvist,

Tested it with the other user script enabled, and it worked great!

Tested with two somewhat large trade (83 items & 73 items) either side, seems to work great too.

Thank you!

EvE-Player commented 10 months ago

Hello @Rudokhvist,

I've noticed it is including trading cards from my inventory and possibly the other persons in the listings which are not currently tradable, is there a check you could possibly implement to avoid this? Untradable Untradable2 Untradable3

Otherwise, all is working as it should!

Thank you

Rudokhvist commented 10 months ago

Sadly, checking for not tradable cards is impossible during matching. And I somehow assumed that those cards should already be filtered during adding to trade phase (can't check it, since I don't have any not tradable cards now). If they are interfering during adding to trade phase I probably can add extra filtering, but it won't solve the problem completely, only will help in cases when you (or the one you trade to) has both tradable and not tradable copies of same card.

EvE-Player commented 10 months ago

I had never noticed before if it included untradeable ones, but as they are only untradeable for a week it's not such a big problem, perhaps its just better to have a bit of patience and wait the week until they become tradable?

Thank you.