search

RudolphRiedel / FT800-FT813

Multi-Platform C code Library for EVE graphics controllers from FTDI / Bridgetek (FT810, FT811, FT812, FT813, BT815, BT816, BT817, BT818)
MIT License
133 stars 58 forks source link

Update FT8.h #1

Closed jventerprises closed 6 years ago

jventerprises commented 6 years ago

BITMAP_LAYOUT_H and BITMAP_SIZE_H macros incorrect for images over 512x512. i have corrected and tested on an ME813a

you need to take the upper 2 bits for each field, but the current macros are taking the lower 2

jventerprises commented 6 years ago

Hi,

it did seem silly to me to have to pre-process the upper bits before calling the macro. That's why macros were invented!

Since you know about the change I deleted the branch and then you dont have to worry about the merge

On Fri, Mar 30, 2018 at 10:51 AM, RudolphRiedel notifications@github.com wrote:

@RudolphRiedel commented on this pull request.

First thank you for the change request. I checked that with the sources from FTDI and their programmers manual, the macros are supposed to be used with only the upper bits of the values. But I am with you on this one and implemented your changes as it just feels more natural to feed the macros with the original values instead of having to calculate the upper bits first.

Second, I am a total github noob, no idea how to close this properly. I do not want to just merge this as I am maintaining a header for each file and edited this as well. Plus I added a warning at the macros as these behave differently than the ones from FTDI.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RudolphRiedel/FT800-FT813/pull/1#pullrequestreview-108349441, or mute the thread https://github.com/notifications/unsubscribe-auth/AR25kAfG4OF7htkVhFdn-S2e--Bpo5Gqks5tjkZvgaJpZM4S3T88 .

RudolphRiedel commented 6 years ago

The FT8xx are full of silly, I only wonder what is found next. :-)