search

RuedigerMoeller / fast-serialization

FST: fast java serialization drop in-replacement
Apache License 2.0
1.59k stars 247 forks source link

Old version of Kryo used in benchmarks #190

Open ghost opened 7 years ago

ghost commented 7 years ago

Hi, interesting to see a Kryo competitor. The benchmarks compare it against 2.23 but the current version is 4.0.0 (the package was changed) https://github.com/EsotericSoftware/kryo/releases. Would also be good to include memory usage as part of the comparison. Thanks!

RuedigerMoeller commented 7 years ago

I have tested the latest version recently and saw major kryo performance regressions in many testcases compared to 2.23/3.0. see https://github.com/RuedigerMoeller/serialization-benchmark (4.0 tests not released). Anyway there is a conceptual difference as fst emulates (and reuses implementations) of standard jdk serialization. In addition I am not interested letting other peoples work look bad, and ofc there might be testcases where kryo performs better.

RuedigerMoeller commented 7 years ago

updated https://github.com/RuedigerMoeller/serialization-benchmark to kryo 4.0.0 . Actually some stuff got better in kryo 4 compared to kryo 3 (still AFAIR slower than kryo 2.23). Kryo has a shorter init time and produces on average ~10 to 20% smaller file/msg sizes, however in most object graph serialization use cases fst2 has a small to medium performance advantage.

RuedigerMoeller commented 7 years ago

btw: to which benchmark link are you referring to ??

ghost commented 7 years ago

https://github.com/RuedigerMoeller/fast-serialization/wiki/Benchmark was the link received from the main website. Might need to correct it if that's also old. Thanks!

RuedigerMoeller commented 7 years ago

Oh .. thanks :)

re-thc commented 5 years ago

The latest Kryo is 5.0.0-RC2. Possible to update the results again? There are lots of big changes in the latest release as well.