search

Rughalt / D35E

3.5e SRD implementation for Foundry VTT.
https://legaciesofthedragon.com
GNU General Public License v3.0
37 stars 30 forks source link

[Bug] Hook `dropActorSheetData` is not invoked. ActorSheetPF `_onDrop` doesn't call super method from base Foundry ActorSheet #847

Closed typhonrt closed 2 years ago

typhonrt commented 2 years ago

Greets,

An issue was filed against Forien's Quest Log about drag & drop functionality relating to dropping rewards / items onto the D35E actor sheet. I looked into it and it appears that ActorSheetPF _onDrop doesn't invoke the super method _onDrop on the base Foundry ActorSheet so the dropActorSheetData hook is never fired. Any module relying on the dropActorSheetData hook including the quest log will have broken functionality.

Suggestion: If possible invoke the super._onDrop so the hooks fire or explicitly invoke the same hooks in your fully overridden _onDrop.

Thanks again for all your work!

See: https://github.com/League-of-Foundry-Developers/foundryvtt-forien-quest-log/issues/5

github-actions[bot] commented 2 years ago

Thanks for opening an issue, traveller! If your issue is related to an actor or an item, sending thing that is broken will help a lot and speed up debugging.

How to send an item? > - If item is owned by a character, drag and drop it to world item list. > - Right click on item in browser item list and click export. > - Attach downloaded item to this ticket. How to send an actor? > - Right click on actor in browser actor list and click export. > - Attach downloaded actor to this ticket.

Rughalt commented 2 years ago

I moved the functions to separate overrides and left _onDrop alone - this seems to keep all functionality and fix this issue. Thanks for reporting.