Rughalt / D35E

3.5e SRD implementation for Foundry VTT.
https://legaciesofthedragon.com
GNU General Public License v3.0
37 stars 30 forks source link

Bug: Special actions don´t work with Babele translations #851

Open irbian opened 2 years ago

irbian commented 2 years ago

https://github.com/irbian/foundryvtt-D35E-lang-es-es/issues/49

As the title says, the "rage" ability from the barbarian class doesn't work when you use the spanish translation module. If you create a barbarian using the english version of the system, "rage" works fine.

I have discovered what's happening: If you edit Rage and go to Configuration/details/Special actions (advanced)/Action , you will read this:

Create unique Enraged from D35E.commonbuffs on self; Set buff Enraged field data.level to 1 on self;Activate buff Enraged on self

The system searches "Enraged" in the compendium, but it doesn't exist anymore because it has been translated. If you write this, the ability works fine again:

Create unique "Furioso (Enraged)" from D35E.commonbuffs on self; Set buff "Furioso (Enraged)" field data.level to 1 on self;Activate buff "Furioso (Enraged)" on self

it can be indeed fixed at translation level, but that would mean that to translate the special actions. We would have to translate twice, once on the buff compendium once on the ability

if I recall correctly the approach you had take it before was to use originalName instead of name whenever this kind of things happens. in this case it would be to search on the compendium based on the originalName and not on the name

I know is a pain, but I think is more maintinable on the long run

Related with https://github.com/Rughalt/D35E/issues/774

github-actions[bot] commented 2 years ago

Thanks for opening an issue, traveller! If your issue is related to an actor or an item, sending thing that is broken will help a lot and speed up debugging.

How to send an item? > - If item is owned by a character, drag and drop it to world item list. > - Right click on item in browser item list and click export. > - Attach downloaded item to this ticket. How to send an actor? > - Right click on actor in browser actor list and click export. > - Attach downloaded actor to this ticket.