Rughalt / D35E

3.5e SRD implementation for Foundry VTT.
https://legaciesofthedragon.com
GNU General Public License v3.0
37 stars 30 forks source link

weight value changed on item after dragging to character sheet #865

Closed wmve closed 2 years ago

wmve commented 2 years ago

steps to reproduce:

  1. define an item with weight .05 (which is the weight of a standard coin)
  2. set quantity to 1200 (note total weight 600)
  3. drag to character sheet expected behaviour: actual behaviour: observed weight on item is 1200. on further inspection the item "each" weight has been changed from .05 to .1

probably a rounding error in some math somewhere. if so please round off only after something like the nearest hundredth. (i know, sometimes those floating point precision errors creep in and add or subtract some very small portion, and you're probably trying to keep that from happening)

left: copy of item in items directory, before drag operation right: copy of item on character sheet after dragging from item directory image

github-actions[bot] commented 2 years ago

Thanks for opening an issue, traveller! If your issue is related to an actor or an item, sending thing that is broken will help a lot and speed up debugging.

How to send an item? > - If item is owned by a character, drag and drop it to world item list. > - Right click on item in browser item list and click export. > - Attach downloaded item to this ticket. How to send an actor? > - Right click on actor in browser actor list and click export. > - Attach downloaded actor to this ticket.

wmve commented 2 years ago

yes, i know there are other ways of tracking coins. i need to keep this loot separate. also, figuring out if the PCs could even carry them all is an issue. if some of them die/disappear i need to know where it all is and how much they have left, as they're frightfully short of money.

Rughalt commented 2 years ago

This turned out to be an issue to weight change for items when dropped to a Large character - their weight was adjusted. To fix that, const weight tickbox should be used.