search

Rughalt / D35E

3.5e SRD implementation for Foundry VTT.
https://legaciesofthedragon.com
GNU General Public License v3.0
37 stars 30 forks source link

Shapechange JS error (wildshape transformation) #890

Closed Johnmish closed 2 years ago

Johnmish commented 2 years ago

when activating a defined shape (wildshape one) from the character sheet, the blue diamond animation never ends. There is a js error in the console (for entity.js).

vtt foundry version: 9 (build 238) srd3.5 version: 0.98.9

Uncaught (in promise) TypeError: o.update is not a function
    _addDefaultChanges https://itwt.fr:30000/systems/D35E/module/actor/entity.js:931
    _updateChanges https://itwt.fr:30000/systems/D35E/module/actor/entity.js:1756
    update https://itwt.fr:30000/systems/D35E/module/actor/entity.js:3915
    applyActionOnSelf https://itwt.fr:30000/systems/D35E/module/actor/entity.js:7562
    update https://itwt.fr:30000/systems/D35E/module/item/entity.js:743
    _setItemActive https://itwt.fr:30000/systems/D35E/module/actor/sheets/base.js:1170
    jQuery 9
    activateListeners https://itwt.fr:30000/systems/D35E/module/actor/sheets/base.js:776
    activateListeners https://itwt.fr:30000/systems/D35E/module/actor/sheets/character.js:67
    _render https://itwt.fr:30000/scripts/foundry.js:3059
    _render https://itwt.fr:30000/scripts/foundry.js:3733
    _render https://itwt.fr:30000/systems/D35E/module/actor/sheets/base.js:2365
    render https://itwt.fr:30000/scripts/foundry.js:2990
    render https://itwt.fr:30000/scripts/foundry.js:4228
    render https://itwt.fr:30000/scripts/foundry.js:10719
    _onUpdate https://itwt.fr:30000/scripts/foundry.js:10773
    _onUpdate https://itwt.fr:30000/scripts/foundry.js:13642
    _onUpdate https://itwt.fr:30000/systems/D35E/module/actor/entity.js:4186
    callback https://itwt.fr:30000/scripts/foundry.js:10203
    documents https://itwt.fr:30000/scripts/foundry.js:10155
    _handleUpdateDocuments https://itwt.fr:30000/scripts/foundry.js:10155
    _updateDocuments https://itwt.fr:30000/scripts/foundry.js:10036
    update https://itwt.fr:30000/common/abstract/backend.mjs:154
entity.js:931:33
github-actions[bot] commented 2 years ago

Thanks for opening an issue, traveller! If your issue is related to an actor or an item, sending thing that is broken will help a lot and speed up debugging.

How to send an item? > - If item is owned by a character, drag and drop it to world item list. > - Right click on item in browser item list and click export. > - Attach downloaded item to this ticket. How to send an actor? > - Right click on actor in browser actor list and click export. > - Attach downloaded actor to this ticket.

skepickle commented 2 years ago

I get the same thing with "Alter Self" defined shapes for my Wizard PC.

Uncaught (in promise) TypeError: o.update is not a function
[Detected 1 package: system:D35E]
    at ActorPF._updateChanges (entity.js:2058)
    at async ActorPF.update (entity.js:3915)
    at async ActorPF.applyActionOnSelf (entity.js:7562)
    at async ItemPF.update (entity.js:743)
    at async ActorSheetPFCharacter._setItemActive (base.js:1170)
_updateChanges @ entity.js:2058
await in _updateChanges (async)
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2
Eldintux commented 2 years ago

Just had a play around, it's the Set Portrait Special Action that's causing the problem. Remove it and it works but obviously doesn't change the Character shape