search

RuiXiong2211 / pe

0 stars 0 forks source link

Forget to capture out of bounds int #1

Open RuiXiong2211 opened 3 years ago

RuiXiong2211 commented 3 years ago

The error message provided should be "The index requested does not exist"

input a number larger than MAX_INTEGER as the index

image.png

vs

image.png

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error thrown doesn't match with the input.

Try to "edit 14321111333 n/Samihah". Error thrown says invalid format. 14321111333 is a positive integer.

image.png

[original: nus-cs2103-AY2021S2/pe-interim#584] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The input provided by the tester might be a positive integer, but it is not in the displayed student list, which is clearly stated in both the UG and the error message

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The error message shown is different? when the positive integer input is below MAX_INTEGER and above MAX_INTEGER according to java constraints. You should catch integers above MAX_INTEGER as well but your error catching currently does not.