RuiXiong2211 / pe

0 stars 0 forks source link

error not thrown for fields that are not changed when edited. #5

Open RuiXiong2211 opened 3 years ago

RuiXiong2211 commented 3 years ago

When editing 1 a person's field, if it changed to something that is exactly the same, an error thrown to say that there were no changes made would be better.

e.g; if the person already lives at RVRC, edit 1 r/RVRC does not throw an error

image.png

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Try to edit an appointment with the same date and time

The error shown "clash with another appointment". It doesn't make sense since it is its own appointment

image.png


[original: nus-cs2103-AY2021S2/pe-interim#583] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is not a bug as the feature still works and does not affect the user at all. For example, in many other applications such as Instagram, if you try to edit your username with the same details as before, the edit will still go through.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is a completely different bug report.


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Having an error thrown out when the user makes no changes during the edit feature can help the user identify whether they have mistyped something or accidentally re-entered the original input since users are unlikely to make no changes when editing.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: The user will be unaware when they have not actually made any edits.