DevTools theme is broken

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Open dev tools in cefclient and resize window to smaller size. 

What is the expected output? What do you see instead?
Background of toolbar must not be transparent, but instead i see that it 
transparent. (See attachment).

What version of the product are you using? On what operating system?
CEF R275.

Please provide any additional information below.
I start investigate this problem and see that it is not os detection / css 
problem.
Actual colors set in DevTools.js (line 63, in devtools.domContentLoaded 
method). Of course it is looks like hack over inspector's css - same thing can 
be solved via css. Strange solution.
It uses WebInspector.queryParamsObject and if toolbar_color and text_color is 
set - it forces colors (by dynamic css). When i open developer tools in chrome 
i see that this object is:
{
docked: "false"
textColor: "rgba(18,50,114,1)"
toolbarColor: "rgba(223,223,223,1)"
}.

WebInspector.queryParamsObject gotten from parseQueryParameters() function in 
inspector.js (~line 388) - it parses window.location.search (it contain 
"?docked=false&toolbarColor=rgba(223,223,223,1)&textColor=rgba(18,50,114,1)").

So, i propose some enchancement to CEF:
1. Specifying custom scheme for devtools (but allow file scheme, as in current 
version).
2. Allow to passing configurable color parameters (in fact it can be not needed 
on macos, 'cause it have different css).
3. Don't know how it can be docked (may be via WebInspector.setAttachedWindow, 
but it don't interested, as i think).

PS: Also i see, that in current cef binary package in devtools missing 
paneFilterButtons.png image.

Original issue reported on code.google.com by fdd...@gmail.com on 22 Aug 2011 at 10:17

Attachments:

• devtools_theme_issue.png

[GoogleCodeExporter]

Thanks, fixed in revision 351 by adding 
"docked=false&toolbarColor=rgba(223,223,223,1)&textColor=rgba(18,50,114,1)" as 
query parameters to devtools.html.

Original comment by magreenb...@gmail.com on 31 Oct 2011 at 6:47

• Changed state: Fixed

[GoogleCodeExporter]

Cool! But as i'm remember, that this parameters really are needed only for 
OS_WIN. For other platforms, as minimum for macosx, background normally 
controlled by css rules. (No have idea why this done too complex in devtools).

Original comment by fdd...@gmail.com on 31 Oct 2011 at 6:53

[GoogleCodeExporter]

Seems not to hurt on Mac. I'll leave it in for consistency between platforms.

Original comment by magreenb...@gmail.com on 31 Oct 2011 at 7:17

[GoogleCodeExporter]

On macosx it have completely different view, i follow only this.
But of course, for development any usable view are good. :)

Original comment by fdd...@gmail.com on 31 Oct 2011 at 7:24

[GoogleCodeExporter]

I am very close (I think) to finally getting rid of the malware that blocked me 
from editing the CL or even poping up a terminal. It gets force enroll 
enterprise into my profiles command line and messes with all versions of image 
burner I've come across. One very distinct thing (on a hp pavillion14 
chromebook) is that after the factory reset is complete and it should auto 
rrestart, it doesn't.
Anyway it has damn near put me out of business with the decrease in performance 
on all my devices. Takes advantage of everything cable provider gateway 
androids desktops (turns them into terminals/tablets basically). I have 100s of 
open tabs at all times, every website including bookmarked ones "I've never 
been to before today", Hidden managed users are about 20 i recently found out. 
Uses SVN and with AT&T at least does something with the "curses library" which 
is just a disgusting pile of code (any legitimate use of it is beyond me) but 
so are alot of things. This level of functionality (edit the dev tools) is 
furthest I've gotten please help. Think I'm crazy? One benefit: 0 advertising

Original comment by transpon...@gmail.com on 23 Nov 2014 at 7:52

Attachments:

• XXXXXXcodemirror.css
• NoDomainnavigatorView.css