RuidSiel / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
0 stars 1 forks source link

Change Int CefV8Value methods to Int32 and add Uint32 #331

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
CEF currently provides CefV8Value methods for "Int" type like IsInt(), 
GetIntValue(), etc that use the int data type. This naming and usage is 
somewhat misleading because JavaScript (and V8) only support 32 bit integers 
(see http://code.google.com/p/v8/issues/detail?id=973 for more information). 
Also, while V8 supports unsigned 32 bit integers CEF does not currently expose 
that type via the API.

The proposal is to rename the existing "Int" methods to "Int32" and add new 
"Uint32" methods. These methods would then use new int32 and uint32 data types 
respectively.

Original issue reported on code.google.com by magreenb...@gmail.com on 8 Sep 2011 at 5:28

GoogleCodeExporter commented 9 years ago
CEF3 revision 523 adds a new CefV8Value::CreateUInt method and indicates that 
integer types are 32bit via usage of int32 and uint32 types.

Original comment by magreenb...@gmail.com on 12 Mar 2012 at 11:48

GoogleCodeExporter commented 9 years ago
Done in CEF1 trunk revision 644.

Original comment by magreenb...@gmail.com on 23 May 2012 at 7:04