GetAuthCredentials (CefRequestHandler) is never called

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Put a breakpoint in GetAuthCredentials
2. Browse to a URL that requires authentication and where you don't have 
credentials that can be automatically passed through (single sign-on)
3. See that your breakpoint is never hit.

Should see a call to GetAuthCredentials in this situation.
Prior to the CEF API change, HandleAuthenticationRequest was called in this 
situation.

Bug exists in r193, r275 and r259.
OS is Windows XP.

Original issue reported on code.google.com by powerbf...@gmail.com on 28 Sep 2011 at 6:12

[GoogleCodeExporter]

Correction: that should be r293 above, not r193.

Original comment by powerbf...@gmail.com on 28 Sep 2011 at 7:34

[GoogleCodeExporter]

On Further investigation, it seems that GetAuthCredentials *is* called for 
"basic" and "digest" authentication schemes.

I tested basic authentication here:
http://test.webdav.org/auth-basic/

and digest authentication here:
http://test.webdav.org/auth-digest/

However, with our internal servers which are using Windows Authentication (not 
sure if that means ntlm or negotiate authentication scheme):
A client built with CEF r212 will get a HandleAuthenticationRequest call.
A client built with CEF r293, r275, or r259 will not get a GetAuthCredentials 
call.

Original comment by powerbf...@gmail.com on 28 Sep 2011 at 7:36

[GoogleCodeExporter]

This issues is preventing us from moving to r365 of CEF :(

Original comment by custa1...@gmail.com on 9 Nov 2011 at 2:17

[GoogleCodeExporter]

@comment#3: I don't have systems to test Windows Authentication so you might 
need to debug this one yourself. Patches welcome.

Original comment by magreenb...@gmail.com on 9 Nov 2011 at 2:30

[GoogleCodeExporter]

Debugging showed that request_handler_get_auth_credentials() is being passed a 
null pointer for "realm" and the funtion exits without doing anything under 
this condition (request_handler_cpptoc.cc line 151).

After taking out the test for a null "realm", I got the call to 
GetAuthCredentials and was able to login ok.

I don't know enough about this area to know if having a null realm is valid, 
but since I was able to login under that condition, I guess it is.

Anyway, your patch, should you choose to accept it ;), is attached.

By the way, we are using IIS as our web server.

Original comment by powerbf...@gmail.com on 25 Nov 2011 at 7:23

Attachments:

• authentication_patch.txt

[GoogleCodeExporter]

Original comment by magreenb...@gmail.com on 8 Dec 2011 at 1:17

• Changed state: Accepted
• Added labels: NextRelease

[GoogleCodeExporter]

Fixed in revision 425.

Original comment by magreenb...@gmail.com on 16 Dec 2011 at 1:50

• Changed state: Fixed

[GoogleCodeExporter]

I can confirm that this is working in versions 1.1046.516 and 1.1025.508

Original comment by powerbf...@gmail.com on 2 Mar 2012 at 1:59