search

Ruin0x11 / lsp-intellij-spacemacs

Spacemacs layer for intellij-lsp-server
26 stars 5 forks source link

Configuration uses `spacemacs|add-company-hook`, which is removed in spacemacs/develop #1

Closed RichardDRJ closed 6 years ago

RichardDRJ commented 6 years ago

I've got an alternative config for users of the develop branch of Spacemacs, in this branch, but I can't see an easy way to raise a PR which creates a branch at the same time - I think this change should be on a develop branch in this repo, so that both bleeding-edge and non-bleeding-edge Spacemacs users have an easy option.

This change also introduces Spacemacs-like keybindings for lsp-intellij.

Thanks, Richard

Ruin0x11 commented 6 years ago

I wonder how other Spacemacs packages would deal with this. It would be nice if we had a version that worked on both versions of Spacemacs. If not then I can make the current repo the stable branch and merge the bleeding-edge changes into master, then add somehing in the README.

beyondpie commented 6 years ago

@CatharticMonkey @Ruin0x11 I see both of you have big differences in spacemacs/lsp-intellij. Is it good to combine them? And send a PR to spacemacs?

RichardDRJ commented 6 years ago

@Ruin0x11 Yeah, I like that. Built-in layers deal with it by being bundled with the correct version, but I have no idea how 3P layers usually would. I've added a version check to differentiate between master's HEAD and develop's HEAD, and load the correct config based on that, which is in this PR.

@songpeng Yep, the PR I've raised on this repo combines the config. I'm not sure it's worth sending a PR to Spacemacs right now, though; there seems to be some churn coming up to the 0.300 release, and then once that's done there's talk of changing how contributions are reviewed and merged, to remove the bottleneck of a single maintainer. I'd be inclined to wait a little bit before trying to get this merged into mainline Spacemacs.