RuiyuM / STONE

This is the official website for the implementation of the "STONE: A Submodular Optimization Framework for Active 3D Object Detection" method, as presented in the NeurIPS 2024 paper.
Apache License 2.0
3 stars 0 forks source link

Missing config and hard-coded selection budget #1

Open GerritBartels opened 7 hours ago

GerritBartels commented 7 hours ago

First off, thank you for your exciting contribution to the field of Active Learning for LiDAR-based 3D Object Detection!

While going through your code, I stumbled upon two things:

See pcdet/query_strategies/STONE_sampling.py line 375-386:

        # returned the index of acquired bounding boxes
        if len(selected_frames_final) < 100:
            # Calculate how many elements to extract from selected_frames
            elements_needed = 100 - len(selected_frames_final)

            # Extract the top elements_needed from selected_frames
            top_elements = selected_frames[:elements_needed]

            # Append extracted elements to selected_frames_final
            selected_frames_final.extend(top_elements)

        return selected_frames_final

Thank you in advance and kind regards, Gerrit

RuiyuM commented 4 hours ago

Hi Gerrit Bartels,

Thank you for your feedback! I really appreciate you pointing out the issues with my configuration. I will definitely spend more time working on that aspect to improve it.

Regarding the budget hardcoded to 100, there isn’t a specific reason behind this choice—it simply follows the setup from the previous work (https://github.com/Luoyadan/CRB-active-3Ddet). However, you are absolutely free to adjust the budget. If your active learning method achieves good results with a lower budget, that would be a great improvement, and reducing the budget across all baselines would make sense.

Thanks again! Ruiyu