Ruizhi2001 / pe

0 stars 0 forks source link

Unable to remove ingredients from recipe #2

Open Ruizhi2001 opened 10 months ago

Ruizhi2001 commented 10 months ago

In the DG the use case here is that the baker wants to be able to modify his recipe but there is no function that indicates that is possible. This is a feature flaw as it does not fulfil the stated problem of the intended user. It is also not stated in the planned enhancements that this will be a future implementation.

image.png

image.png

nus-pe-script commented 10 months ago

Team's Response

The functionality of the modify recipe command is intended for scaling or changing the ratios of ingredients in a recipe. Removing ingredients entirely from a recipe, in our opinion, modifies the recipe too greatly and the user should instead create another recipe, which a fast typer should be able to do somewhat quickly.

As such, while we do accept that this is a suboptimal design of the feature, we felt this is not in scope as this is a less important aspect as compared to actually modifying the ingredient ratio.

In addition, our feature does not support functionality to remove any ingredient from the ingredient list in the recipe (as seen by how quantity has to be positive). This combined with our earlier reasoning qualifies this bug as not in scope.

Screenshot 2023-11-19 224331.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The user story in this case states that a baker wants to modify the recipe. While it is possible to modify the ratios, the inability to remove ingredients significantly limits the ability for the baker to modify his/her recipe or even scale his/her recipe.
For example the baker wants to improve the recipe by removing vanilla essence for vanilla beans he is not able to do so and even if the baker is a fast typist, I believe it is unreasonable to request for the baker to rewrite the whole recipe.
You mentioned that the point of this function is not to change the recipe drastically and as such the option to remove an ingredient is unavailable.
However, this seems to be inconsistent with your function as it is possible to add ingredients to the recipe as mentioned in your user guide. If removing an ingredient is a drastic change, surely adding in one is too but it is allowed in this case.
image.png
As such, I argue that being able to delete is a feature that is as important as its counterpart adding, and modifying the ratios. The ability to delete is in the scope of the project.