Rule-34 / App

Browse the most popular Boorus with the Rule 34 App.
https://r34.app
GNU Affero General Public License v3.0
171 stars 25 forks source link

Deployment Fails when Installing Packages #64

Closed Ben-Brady closed 2 years ago

Ben-Brady commented 2 years ago

Describe the bug

Installing the packages fails with an error code

To Reproduce

Steps to reproduce the behavior:

  1. Clone the repository
  2. run npm install / npm install --force
  3. The Install Fails

Expected behavior

The package installation should happen successfully

Screenshots

ben@slate:~/Downloads/App$ npm install
npm WARN deprecated @types/browserslist@4.15.0: This is a stub types definition. browserslist provides its own type definitions, so you do not need this installed.
npm WARN deprecated @types/anymatch@3.0.0: This is a stub types definition. anymatch provides its own type definitions, so you do not need this installed.
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated flatten@1.0.3: flatten is deprecated in favor of utility frameworks such as lodash.
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated querystring@0.2.0: The
npm WARN deprecated svgo@1.3.2: This SVGO version is no longer supported. Upgrade to v2.x.x.
npm WARN deprecated core-js@2.6.12: core-js@<3.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
npm ERR! code 1
npm ERR! path /home/ben/Downloads/App/node_modules/@sentry/cli
npm ERR! command failed
npm ERR! command sh -c node scripts/install.js

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/ben/.npm/_logs/2022-02-20T13_39_24_452Z-debug-0.log

Desktop (please complete the following information)

Additional context

npm.log

AlejandroAkbal commented 2 years ago

Weird, its working for me, are you using Node 16?

added 1848 packages, and audited 1849 packages in 36s

151 packages are looking for funding
  run `npm fund` for details

100 vulnerabilities (92 moderate, 8 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
Ben-Brady commented 2 years ago

Yeah, I just tried it installing it with different versions and only Node v12-14 works with any version past that failing. If your not gonna support those versions, could you specify it in the requirements.

AlejandroAkbal commented 2 years ago

Node's version is actually specified in the package.json file.

Just updated the dependencies, give it a try with Node's Gallium LTS.

Ben-Brady commented 2 years ago

Worked Perfectly. However could you mention using git clone --recursively in the README so it installs the Shared-Resourses. By default git clone doesn't do that and it isn't clear you to install the Shared-Resources.