RuleWorld / bionetgen

Rule-based modeling framework
https://bionetgen.org/
MIT License
59 stars 25 forks source link

Incomplete error handling in RxnRule.pm #213

Closed jrfaeder closed 5 years ago

jrfaeder commented 5 years ago

It is possible to write invalid cBNGL rules that do not produce reactions but do not cause BNG to exit even though they generate an ERROR message. Attached is an example of a model file that exhibits this behavior. Searching on the string "ERROR" reveals several instances where an error is indicated but handled by a "return undef" instead of "exit_error." This should be addressed to prevent continuation of simulation or analysis on models with invalid rules. organelle_transport_struct.bngl.txt