Ruleby / ruleby

the Rules Engine for Ruby
http://www.ruleby.org
Other
327 stars 42 forks source link

Allowing "engine" method in the global namespace conflicts with Rails 3.1+ #23

Open pmarreck opened 12 years ago

pmarreck commented 12 years ago

There is an "engine" method defined on ActiveRecord::Relation and under certain circumstances this will conflict with the "engine" method that is defined on Object by the inclusion of "include Ruleby" without a surrounding class.

Also, any word on updating this gem?

jkutner commented 12 years ago

Is it not sufficient to avoid including Ruleby without a surrounding class?

On Sep 27, 2012, at 10:05 AM, Peter Marreck wrote:

There is an "engine" method defined on ActiveRecord::Relation and under certain circumstances this will conflict with the "engine" method that is defined on Object by the inclusion of "include Ruleby" without a surrounding class.

Also, any word on updating this gem?

— Reply to this email directly or view it on GitHub.

pmarreck commented 11 years ago

There are 2 other places in the Ruleby code (at the time I looked at this) which call "engine" without an object or namespace specified, that would need to be changed in addition.

Also, Github is bad at notifying me when there is a comment on something I am participating in :O