Problems with ruins - Githubissues

Rumsfield / konquest

Konquest plugin for Spigot Minecraft territory control

GNU General Public License v3.0

8 stars 3 forks source link

Problems with ruins #114

Closed Rumsfield closed 1 year ago

Rumsfield commented 1 year ago

When critical blocks are destroyed in a ruin and the server restarts, the critical blocks do not re-appear. Also, ruin golems spawn out of control.

[x] Update golem spawn mechanics: remove when chunks unload, respawn when outside of ruin territory, prune/spawn after chunk loads and player enters territory.
[x] Regenerate all critical blocks in all ruins on plugin disable.

Rumsfield commented 1 year ago

Golems don't get pruned when the chunks are unloaded (player teleports from far away, typically an admin).

Rumsfield commented 1 year ago

Tests

Ruin chunks loaded (player present) while server shuts down
- Golem is removed and spawned correctly on player join inside of ruin
Ruin chunks are unloaded while server shuts down
- Golem is not removed on disable (debug says that the entity was removed, but it's still there)
- Golem is not pruned on teleport (chunk was unloaded during pruning)
- Golem is pruned on entry (already loaded chunks)

Rumsfield commented 1 year ago

The Ruin Golem spawning mechanics should be reworked so that all ruin golems are removed when their chunks unload, and then get spawned back when a player enters the ruin territory.