search

Rumsfield / konquest

Konquest plugin for Spigot Minecraft territory control
GNU General Public License v3.0
7 stars 2 forks source link

NPE occurs in Dynmap renderer #118

Open Rumsfield opened 1 year ago

Rumsfield commented 1 year ago

Add checks to ensure dynmap API is not null.

05.08 07:02:40 [Server] INFO Caused by: java.lang.NullPointerException: Cannot invoke "org.dynmap.DynmapCore.getMarkerAPI()" because "this.core" is null
05.08 07:02:40 [Server] INFO at org.dynmap.bukkit.DynmapPlugin.getMarkerAPI(DynmapPlugin.java:1145) ~[Dynmap-3.4-spigot.jar:?]
05.08 07:02:40 [Server] INFO at com.github.rumsfield.konquest.map.DynmapRender.getIconMarker(DynmapRender.java:370) ~[Konquest-0.12.0.jar:?]
05.08 07:02:40 [Server] INFO at com.github.rumsfield.konquest.map.DynmapRender.drawUpdate(DynmapRender.java:88) ~[Konquest-0.12.0.jar:?]
05.08 07:02:40 [Server] INFO at com.github.rumsfield.konquest.map.MapHandler.drawUpdateTerritory(MapHandler.java:63) ~[Konquest-0.12.0.jar:?]
05.08 07:02:40 [Server] INFO at com.github.rumsfield.konquest.manager.SanctuaryManager.addSanctuary(SanctuaryManager.java:74) ~[Konquest-0.12.0.jar:?]
05.08 07:02:40 [Server] INFO at com.github.rumsfield.konquest.command.admin.SanctuaryAdminCommand.execute(SanctuaryAdminCommand.java:53) ~[Konquest-0.12.0.jar:?]
05.08 07:02:40 [Server] INFO at com.github.rumsfield.konquest.command.admin.AdminCommand.execute(AdminCommand.java:64) ~[Konquest-0.12.0.jar:?]
05.08 07:02:40 [Server] INFO at com.github.rumsfield.konquest.command.CommandHandler.onCommand(CommandHandler.java:56) ~[Konquest-0.12.0.jar:?]
05.08 07:02:40 [Server] INFO at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[paper-api-1.20.1-R0.1-SNAPSHOT.jar:?]
Rumsfield commented 1 year ago

This only happens in older versions of Dynmap that do not enable successfully. Latest Dynmap versions still work.

Need to update the Dynmap hook to use the latest API listener for when the api is enabled: https://github.com/webbukkit/dynmap/wiki/Dynmap-API#accessing-the-dynmap-api