Rumsfield / konquest

Konquest plugin for Spigot Minecraft territory control

GNU General Public License v3.0

7 stars 2 forks source link

Feature/67 jitpack package repo #191

Closed TropicalShadow closed 7 months ago

TropicalShadow commented 7 months ago

Konquest Pull Request

Closes #38 #67

Summary

allow JitPack to be a maven repository for the plugin api

Change Details

added jitpack.yml to tell Jitpack to use Java 11
update API module to use Java 11
add maven publication in API module for JitPack to use
remove shadowJar from API module (not needed, and conflicted with maven publication)
fixed "dynmap" to "Dynmap" in the core module

Checklist

[x] I have merged the latest develop commit into this branch and resolved any conflicts.
[x] I have tested this branch and it is working as intended.
[x] This Pull Request is ready for review and merging.

Rumsfield commented 7 months ago

A fresh clone of your forked repo on the feature/67 branch builds fine and the changes look good. I'm not familiar with JitPack. Can you please comment with example code of how to include the Konquest API in other projects, similar to this LuckPerms example?

TropicalShadow commented 7 months ago

Jitpack will handle most of the heavy lifting entirely. if you check out this link, you can see it will try to scan the project and make packages available for all versions, the code in this branch just fixes a few things to ensure Jitpack can actually compile the API.

it also provides you with all the code you will need but for ease of use. I would recommend the following.

for build.gradle.kts

repositories {
    maven("https://jitpack.io")
}

dependencies {
    implementation("com.github.Rumsfield:konquest:Tag")
}

replacing Tag with the release version or commit hash (provided by Jitpack's website)