Bugfix: Unhandled DNS lookup error and image parsing.

[MorningLightMountain713]

Two things going on here.

First, the image parsing was missing a return statement if no match at all was made (edge case), which somehow allowed for an image starting with a / to be accepted. I'm not sure how this app even got registered, as I tested it on the home.runonflux.io register page, and it throws an error.

I will add some tests in for this tomorrow.

Second, when FluxOS goes to remove the app (the image doesn't exist) it's causing a dns lookup to fail somewhere for the hostname "images" I can't track this down at the moment, so have put a hack in place so we catch this error globally, and continue on.

With patch:

Uncaught DNS Lookup Error!!, swallowing.
Error: cacheableLookup ENOTFOUND images
    at CacheableLookup.lookupAsync (file:///home/davew/zelflux/node_modules/cacheable-lookup/source/index.js:202:18) {
code: 'ENOTFOUND',
hostname: 'images'
}

It has to be one of the axios calls as that is the only thing using cacheable lookups. I will try find this tomorrow - I can replicate the error by putting this blob back in the db:

  {
    name: 'gridprueba',
    compose: [
      {
        name: 'Webserver',
        description: 'grid',
        repotag: '/nginx:latest',
        ports: [ 34349 ],
        domains: [ '' ],
        environmentParameters: [],
        commands: [],
        containerPorts: [ 80 ],
        containerData: '/tmp',
        cpu: 0.5,
        ram: 500,
        hdd: 15,
        tiered: false,
        secrets: '',
        repoauth: ''
      }
    ],
    contacts: [],
    description: 'asd',
    expire: 5000,
    geolocation: [],
    hash: '6718b5e140301c815ef2f8f0fec1a6ad8fa853f68b85a69828cfaa8f75470910',
    height: 1702605,
    instances: 3,
    nodes: [],
    owner: '1Ltfpyy1PuUuqaX8QT59nZ6UD2WURedBSF',
    staticip: false,
    version: 7
  }

[gitguardian[bot]]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [8398280](https://dashboard.gitguardian.com/workspace/457058/incidents/8398280?occurrence=161901872) | Triggered | PGP Private Key | bf5252b76a1aca254eee3cf76cb3d5bc22c0cd54 | HomeUI/dist/js/index.js | [View secret](https://github.com/RunOnFlux/flux/commit/bf5252b76a1aca254eee3cf76cb3d5bc22c0cd54#diff-5ff8e4ac919410ee57580673c614ed6cb7e1d235864f103d10932cbd9ccd7783L1) | | [8398280](https://dashboard.gitguardian.com/workspace/457058/incidents/8398280?occurrence=161901878) | Triggered | PGP Private Key | bf5252b76a1aca254eee3cf76cb3d5bc22c0cd54 | HomeUI/dist/js/index.js | [View secret](https://github.com/RunOnFlux/flux/commit/bf5252b76a1aca254eee3cf76cb3d5bc22c0cd54#diff-5ff8e4ac919410ee57580673c614ed6cb7e1d235864f103d10932cbd9ccd7783R1) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/private_key_pgp#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[MorningLightMountain713]

Will redo against develop