bytetigers commented 2 months ago

Application whitelist

fix some comments

What do you want to Run On Flux?

Please describe what application(s) do you plan to run.

Is your desired application running somewhere already?

Please provide a POC link to application if it is already running somewhere. (optional)

Is your application open source?

Please provide a source code (optional)

Checklist:

[ ] Whitelist of application is only modifying repositories.json file
[ ] repositories.json is still a valid JSON file
[ ] Only whitelists single docker image organisation (one whitelist at a time, more whitelists, more PRs)
[ ] No other whitelist has been deleted
[ ] I agree with ToS https://cdn.runonflux.io/Flux_Terms_of_Service.pdf
[ ] Application follows ToS - Application is not malicious. Application is not a scam. Application does what is meant to do and does not mislead in any way. Application does not do anything illegal. Application is not a mining application (not even bandwidth mining).
[ ] In case application receives multiple reports, behaves maliciously, it will be blacklisted and removed from the network.

darrenvechain commented 2 months ago

Hi, FYI this looks like a bot farming trust. The user has raised 12 PRs in as many minutes, fixing only typos.

https://github.com/hyperium/tonic/pull/1869 https://github.com/vechain/thor/pull/817 https://github.com/sushiswap/sushiswap/pull/1606 https://github.com/ReactiveX/RxJava/pull/7749 https://github.com/UMAprotocol/protocol/pull/4778/files https://github.com/zcash/librustzcash/pull/1494/files https://github.com/harmony-one/harmony/pull/4734 https://github.com/RunOnFlux/flux/pull/1387 https://github.com/gluwa/creditcoin/pull/1688  https://github.com/bandprotocol/chain/pull/415  https://github.com/centrifuge/centrifuge-chain/pull/1963  https://github.com/bcnmy/biconomy-client-sdk/pull/558

bytetigers commented 2 months ago

Hi, FYI this looks like a bot farming trust. The user has raised 12 PRs in as many minutes, fixing only typos.

hyperium/tonic#1869 vechain/thor#817 sushiswap/sushiswap#1606 ReactiveX/RxJava#7749 https://github.com/UMAprotocol/protocol/pull/4778/files https://github.com/zcash/librustzcash/pull/1494/files harmony-one/harmony#4734 #1387 https://github.com/gluwa/creditcoin/pull/1688  https://github.com/bandprotocol/chain/pull/415  https://github.com/centrifuge/centrifuge-chain/pull/1963  bcnmy/biconomy-client-sdk#558

First of all, I am not a robot. I submitted all of them manually. Some of the identification and judgment took a lot of time.

I submitted a method to fix the method name to the https://github.com/vechain/thor/pulls project you maintain. If you think it is worthless, you can close it. Please don't think that others are like you and think it is insignificant.

Don't comment under each PR, which reflects your self-righteousness and poor quality.

As the maintainer of this project said, I don't think there is anything wrong with such changes https://github.com/gluwa/creditcoin/pull/1688

gitguardian[bot] commented 2 months ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [8398280](https://dashboard.gitguardian.com/workspace/457058/incidents/8398280?occurrence=161901872) | Triggered | PGP Private Key | bf5252b76a1aca254eee3cf76cb3d5bc22c0cd54 | HomeUI/dist/js/index.js | [View secret](https://github.com/RunOnFlux/flux/commit/bf5252b76a1aca254eee3cf76cb3d5bc22c0cd54#diff-5ff8e4ac919410ee57580673c614ed6cb7e1d235864f103d10932cbd9ccd7783L1) | | [8398280](https://dashboard.gitguardian.com/workspace/457058/incidents/8398280?occurrence=162705153) | Triggered | PGP Private Key | 304dd6f2a25ccb1c0d17b6c9c8dad3bcc49900ad | HomeUI/dist/js/index.js | [View secret](https://github.com/RunOnFlux/flux/commit/304dd6f2a25ccb1c0d17b6c9c8dad3bcc49900ad#diff-5ff8e4ac919410ee57580673c614ed6cb7e1d235864f103d10932cbd9ccd7783R1) | | [8398280](https://dashboard.gitguardian.com/workspace/457058/incidents/8398280?occurrence=162705154) | Triggered | PGP Private Key | 304dd6f2a25ccb1c0d17b6c9c8dad3bcc49900ad | HomeUI/dist/js/index.js | [View secret](https://github.com/RunOnFlux/flux/commit/304dd6f2a25ccb1c0d17b6c9c8dad3bcc49900ad#diff-5ff8e4ac919410ee57580673c614ed6cb7e1d235864f103d10932cbd9ccd7783L1) | | [8398280](https://dashboard.gitguardian.com/workspace/457058/incidents/8398280?occurrence=161901878) | Triggered | PGP Private Key | bf5252b76a1aca254eee3cf76cb3d5bc22c0cd54 | HomeUI/dist/js/index.js | [View secret](https://github.com/RunOnFlux/flux/commit/bf5252b76a1aca254eee3cf76cb3d5bc22c0cd54#diff-5ff8e4ac919410ee57580673c614ed6cb7e1d235864f103d10932cbd9ccd7783R1) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/private_key_pgp#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

RunOnFlux / flux

chore: fix some comments #1387