search

RunSignUp-Team / RunSignup-Mobile-Timing-App

Apache License 2.0
3 stars 0 forks source link

v2 Review - Chute Mode Bibs Not Pushed #51

Closed nathanael-rsu closed 1 year ago

nathanael-rsu commented 2 years ago

Major bug @chelseaRSU found. When we saved in Finish Line Mode, we were pushing checker bibs whether or not they were all 0s. Then, when we saved in Chute Mode, if there were results at RSU (which there were, as an array of 0s), we didn't push anything to RSU. So basically, the normal flow of Finish Line Mode and then Chute Mode was broken, unless the user made an edit in Results and re-pushed the correct data to RSU. This has been here since v1 and somehow we missed it.

nathanael-rsu commented 2 years ago

Update: there is a secondary piece of this issue that makes the previous comment obsolete. Because even with the fix I made for that earlier comment, we still had another issue. The case is that the user pushes up these checker bibs: [1, 2, 3, 0]. Then, the enter chute mode and try to push up these bibs: [1, 2, 3, 4]. Those bibs will not push up to RSU, because the checker bibs are already there. But they will also never push up in Results Mode, because there are no conflicts to resolve.

So the real solution to both of these issues is to always push checker bibs from Finish Line Mode, but when we check if there are bibs at RSU in Chute Mode during the save process, we immediately push up the bib numbers from Chute Mode if there are no conflicts. Basically, we will have a mini version of the Results Mode conflict logic in Chute Mode.