search

RuneMate / Issues

Client and API Issue tracking. See README for more information.
8 stars 0 forks source link

Add Legendary Pet support to Beast of Burden / Summoning API #30

Open rossity opened 5 years ago

rossity commented 5 years ago

Is your feature request related to a problem? Please describe. It is related to how the API currently handles BoB. It seems like it cycles through a list of BoBs and sees if any are targeting the player?

Describe the solution you'd like Essentially, it would be nice to have functions like Summoning.Familiar.getMinutesAvailable() or be Summoning.Familiar.getInventorySize()available to Legendary Pets acting as Beasts of Burden.

Describe alternatives you've considered The above functions could potentially be able to be used even if your current familiar/pet isn't in the list of all familiars (they currently do not, tested via DevKit). Maybe by checking the value of the text over the BoB buff you get? Or by checking if the BoB Inventory is open. It seems that the values aren't available if you don't have a compatible BoB summoned.

Additional context Legendary Pets can be purchased with Runecoins but are a must have for most maxed accounts. They have access to abilities that allow them to auto-loot items off of the ground, finish off slayer monsters automatically, and even act as a beast of burden (while retaining the other abilities). They are an excellent resource and alternative to regular Beasts of Burden. They aren't true summoning familiars though, and while using a Pack Yak pouch on a Legendary Pet allows it to act as a Pack Yak, it does not become a Pack Yak. It retains its name (either its default name or whatever you named it) and form (listed in link).

ccarpenter04 commented 5 years ago

Since you seem to have an in depth knowledge of this enhancement, would you mind attempting a prototype of some of the methods and we can work on merging it into the codebase after the api is more fleshed out than just a few thoughts.

rossity commented 5 years ago

I started learning Java 3 days ago, so it might be a little while before I have that kind of code quality! I've been able to put a bot together, but I'm not sure I understand how things work enough yet to start toying with the API.