RuneMate / Issues

Client and API Issue tracking. See README for more information.
8 stars 0 forks source link

High resolutions cause RM client to run out of memory when loading many pages #36

Open ghost opened 5 years ago

ghost commented 5 years ago

Describe the bug When you run the Runemate client at high resolution, and navigate through multiple pages, and have a bot running, the RM client will inevitably run out of memory and freeze/crash/distort. JFX uses more memory for displaying stuff + caching larger data, and you have the bot UI on top of it.

Cloud: "run out of memory on high res displays such as when enlarged or maximized. doesn't always crash or freeze immediately but distorts. 3440x1440 (UHD?) 3840x2160 (4k, w/HDR)"

Affected game modes: OSRS confirmed. RS3 very likely due to nature of bug.

RuneMate version: 2.95.17, and many previous versions.

To Reproduce Steps to reproduce the behaviour:

  1. Run RM on high resolution monitor
  2. Load multiple pages (account, bot overview, add instance, etc) + a bot with UI
  3. Wait

Please include the code used to produce this bug. Any bot with UI.

Expected behaviour No freezing/crashing/distorting.

Screenshots N/A

Additional context 3440x1440 (UHD?) 3840x2160 (4k, w/HDR)

ccarpenter04 commented 5 years ago

Resizing to a larger resolution is a quick way to trigger it. I was running with -Xmx1400M but this looks to be being done off heap to some extent also.

ghost commented 5 years ago

I use -sdk -login=usn:pw -Xmx1300M as run config

ccarpenter04 commented 5 years ago

As a result of JavaFX making heavy use of off-heap memory and 32bit processes generally being limited to accessing 2GB of RAM on Windows, allocating less memory for the heap actually makes this issue occur less at the obvious expenses.