search

RunestoneInteractive / RunestoneComponents

Packaging of the Runestone tools for publishing educational materials using github pages
http://runestoneinteractive.org
Other
101 stars 225 forks source link

Improve testing 14 #1175

Closed bjones1 closed 3 years ago

bjones1 commented 3 years ago

Updates for activecode -- mostly, tweaks to imports and a rename of one div. Another from #1148.

bjones1 commented 3 years ago

@bnmnetp, would you check? All the tested pass, but the build was for some reason canceled just after they passed. Perhaps re-run the tests?

bjones1 commented 3 years ago

@bnmnetp, would you take a look when you have time? I can't get this to fail locally, and debugging via GH Actions is quite slow and painful.

bnmnetp commented 3 years ago

I've tried re-running multiple times... trying again now.

bjones1 commented 3 years ago

@bnmnetp, this is finally working. However, a bunch of commits are a mess. After you review it, would you like me to squash and force-push something cleaner?

bnmnetp commented 3 years ago

@bjones1 -- something is still not quite right with this.... I just pulled this to my dev environment and used it to build the overview book. In the timed exam on the Dynamic Questions page (uses selecquestion) I cannot edit or do anything with the 4th question (an activecode) I can't edit it and the run button does not seem to be responsive as well as the Caption is showing which should not be the case in a timed exam.

Nevermind... Too much overuse of the same example codes and I ended up with two units 2 on the same page.

bjones1 commented 3 years ago

OK, sounds good. Thanks for doing the manual testing to verify!

I'm getting close to being able to merge a timed question that exercises more of the question types inside it, which we should also be able to run server side as well.