Clean: removed unused config values.

RunestoneInteractive / RunestoneComponents

Packaging of the Runestone tools for publishing educational materials using github pages

http://runestoneinteractive.org

Other

101 stars 225 forks source link

Clean: removed unused config values. #1211

Closed bjones1 closed 3 years ago

bjones1 commented 3 years ago

More clean-up tasks: make the configuration for a book simpler where possible. In this case, remove unused or redundant settings:

The courses table has the login_required flag, and it's been moved there. Remove it from the Sphinx book config.
Likewise, logLevel is used once in the JS: if (eBookConfig.useRunestoneServices && eBookConfig.logLevel > 0). Remove it, since useRunestoneServices can be examined instead of looking at both.

bnmnetp commented 3 years ago

The intention of loglevel was to provide some flexibility in what may or may not get logged beyond a simple binary yes or no.

bjones1 commented 3 years ago

Given that it's not used in the code currently, how about removing it until we have a need? When needed, adding a field to the DB would be a more flexible way to insert logging.

bjones1 commented 3 years ago

Hmm, closing this one then.