Template cleanup - Githubissues

RunestoneInteractive / RunestoneComponents

Packaging of the Runestone tools for publishing educational materials using github pages

http://runestoneinteractive.org

Other

101 stars 225 forks source link

Template cleanup #1217

Closed ascholerChemeketa closed 3 years ago

ascholerChemeketa commented 3 years ago

A bunch of small edits focused on valid modern HTML and accessibility:

Change attr quotes to "
Remove duplicative/orphaned tags and unneeded attrs
Set lang on HTML using pavement.tmpl
aria-label for page progress

bnmnetp commented 3 years ago

Thanks I appreciate the PR.

The unit tests are failing for the codelens component. I can reproduce it consistently with

cd runestone/codelens/test
runestone build --all serve --port 8000

Now bring up localhost:8000/ in your browser and you will get several assertion errors. This does not happen on master, just on this PR.

ascholerChemeketa commented 3 years ago

OK, working on that - something odd is going on. When I serve on windows and browse in Windows I do not get the failed assertions. When I serve from linux VM and browse in Windows, I do. Will get it figured out and then update.