Template cleanup - Githubissues

RunestoneInteractive / RunestoneComponents

Packaging of the Runestone tools for publishing educational materials using github pages

http://runestoneinteractive.org

Other

101 stars 225 forks source link

Template cleanup #1221

Closed ascholerChemeketa closed 3 years ago

ascholerChemeketa commented 3 years ago

Revised and reduced version of earlier PR.

Fixes rendering bug caused by multiple class attrs on some elements.
Removes redundant and unwanted meta tags from layout
Removes extraneous div end tag from layout
Removes type attr from scripts

bnmnetp commented 3 years ago

@ascholerChemeketa I think that the three conflicts are pretty simple to resolve, caused by merging your defer pr I'm guessing...

ascholerChemeketa commented 3 years ago

Rebased to current master

bnmnetp commented 3 years ago

Unfortunately I had to undo the moves of the visually hidden. They need to stay on the span containing the aria label or it ends up hiding the icon and the label and there is nothing in the navbar to click on.