search

RunestoneInteractive / RunestoneComponents

Packaging of the Runestone tools for publishing educational materials using github pages
http://runestoneinteractive.org
Other
101 stars 225 forks source link

Fix: Add /ns prefix to ajax paths. #1250

Closed bjones1 closed 3 years ago

bjones1 commented 3 years ago

Add the /ns prefix to JS ajax queries.

TESTING ONLY: this doesn't work if the bookserver is running standalone, instead of under nginx. We need to think about some nice way to support both cases.

bnmnetp commented 3 years ago

I guess we should go back to the equivalent of

eBookConfig.ajaxURL again. eBookConfig.routePrefix maybe??

bjones1 commented 3 years ago

I did something pretty similar, so that this works with the /ns prefix and without it.

bnmnetp commented 3 years ago

My only Nitpicky comment about /ns and new_server_prefix is that soon enough it won't be the "new server" anymore. /bs is maybe not a great prefix 🤪but maybe bks would suffice?

Or.... here is a history question for you /obidos. Do you even recognize that? Do you know its origin?

bjones1 commented 3 years ago

I definitely prefer /bks to /ns. No clue on /obidos...

Would you like a PR to update this? It should only need fixing on the bookserver.

bnmnetp commented 3 years ago

As long as we are in agreement, I will just add it to my next commit, or if you are in a position to be making changes before I do just let me know on slack.

bjones1 commented 3 years ago

Sounds good. I'll let you add it.