search

RunestoneInteractive / RunestoneComponents

Packaging of the Runestone tools for publishing educational materials using github pages
http://runestoneinteractive.org
Other
101 stars 225 forks source link

Fill in the blank questions are giving feedback when they are part of a timed exam with no feedback. #1259

Closed barbarer closed 3 years ago

barbarer commented 3 years ago

I created a timed exam with no feedback, but the fill in the blank questions are providing feedback (telling the user if they are right or wrong. correct-feedback error-feedback @bjones1 - Brad suggested tagging you.

bnmnetp commented 3 years ago

@bjones1 This fell through the cracks in your PR that refactored a lot of fitb. I suspect it is line 202 where renderFeedback is called unconditionally for client side grading. The fix should be easy -- check this.isTimed if that is true then skip the call to renderFeedback the exam will call renderFeedback on its own when appropriate.

This is time critical as Barb has an exam tomorrow. If you can make the fix I should be able to build a new release for Barb tonight.

bjones1 commented 3 years ago

I will work on this.

bjones1 commented 3 years ago

OK, I've reproduced this bug then fixed per @bnmnetp's suggestion. I'm waiting for tests to pass, then will convert this from a draft PR to a normal PR.

bjones1 commented 3 years ago

Tests aren't running. I went ahead and converter this to a standard PR, since it's time-sensitive.