search

RunestoneInteractive / RunestoneComponents

Packaging of the Runestone tools for publishing educational materials using github pages
http://runestoneinteractive.org
Other
101 stars 225 forks source link

Adds "--bodyFont" to div for Codelens print output, in an attempt to … #1273

Closed dsanders12 closed 2 years ago

dsanders12 commented 2 years ago

…solve dark mode text visibility issue within Codelens. Changes font value within dark mode theme, in order to resolve the same issue. No changes are observed within our local website builds; it seems that our CSS is not updating whenever we make a change. We already ran "sudo npm run build", since JavaScript is involved within the Codelens. We rebuilt ThinkCSPY, since we were specifically looking at Codelens examples in Chapter 2.4 of the book. It is confusing because when we make changes to the same CSS on the website itself, after right clicking and using "Inspect", we can see changes. However, it doesn't work when we manipulate the exact same values within our environments. Issue #1749 of RunestoneServer.

bnmnetp commented 2 years ago

I made the same change to pytutor.css to hardcode the color to blue violet and as you can see it is working fine. Which makes me think your container is not set up to use the Runestone components in development mode.

Screen Shot 2021-11-11 at 11 15 28 AM
dsanders12 commented 2 years ago

Okay, thank you for the feedback! I will look into what could be causing the issue in my development environment, do you have any tips for debugging? Also I did not mean to mark the pull request as "Ready to Review" so please disregard that.