Closed bjones1 closed 2 years ago
Why are tests not running?
I marked this as ready for review, hoping to cause tests to run. ???
@bnmnetp, this is ready for review.
Which version of prettier are you using? VSCode is also running prettier on my end. So we should make sure our settings are the same so we are not going back and forth. In this case Your's has just redone all of the indention to be 2 spaces rather than 4 spaces.
Thanks, I should have seen that earlier. I've updated my VSCode to use a tab width of 4 and updated the PR.
If you'd like, I can squash this down to one commit, but it would require a force push.
I haven't pulled it locally so I doubt anyone else has squash and force away.
Thanks for adjusting your tab width.
Thanks for pointing it out! Squashed and much nicer now.
I've updated our contributing.rst file to reflect that tab size and to have people use black and prettier.
👍
Sigh -- Prettier runs by default, so the change is obscured by a lot of WS changes. The real changes in this commit.