search

RunestoneInteractive / RunestoneComponents

Packaging of the Runestone tools for publishing educational materials using github pages
http://runestoneinteractive.org
Other
101 stars 225 forks source link

Fix: Correctly handle the non-server-side case in fitb.js #1309

Closed bjones1 closed 2 years ago

bjones1 commented 2 years ago

Sigh -- Prettier runs by default, so the change is obscured by a lot of WS changes. The real changes in this commit.

bjones1 commented 2 years ago

Why are tests not running?

bjones1 commented 2 years ago

I marked this as ready for review, hoping to cause tests to run. ???

bjones1 commented 2 years ago

@bnmnetp, this is ready for review.

bnmnetp commented 2 years ago

Which version of prettier are you using? VSCode is also running prettier on my end. So we should make sure our settings are the same so we are not going back and forth. In this case Your's has just redone all of the indention to be 2 spaces rather than 4 spaces.

bjones1 commented 2 years ago

Thanks, I should have seen that earlier. I've updated my VSCode to use a tab width of 4 and updated the PR.

bjones1 commented 2 years ago

If you'd like, I can squash this down to one commit, but it would require a force push.

bnmnetp commented 2 years ago

I haven't pulled it locally so I doubt anyone else has squash and force away.

bnmnetp commented 2 years ago

Thanks for adjusting your tab width.

bjones1 commented 2 years ago

Thanks for pointing it out! Squashed and much nicer now.

bnmnetp commented 2 years ago

I've updated our contributing.rst file to reflect that tab size and to have people use black and prettier.

bjones1 commented 2 years ago

👍