search

RunestoneInteractive / RunestoneComponents

Packaging of the Runestone tools for publishing educational materials using github pages
http://runestoneinteractive.org
Other
101 stars 225 forks source link

Auto load history for activecode problems on page load #1362

Closed ascholerChemeketa closed 2 years ago

ascholerChemeketa commented 2 years ago

Remove "Load History" button completely Load historyscrubber on activecode problem initialization

ascholerChemeketa commented 2 years ago

Proposed changes for experiment with automatically loading history for activecode problems.

bnmnetp commented 2 years ago

This looks good except for in a timed exam. Yeah welcome to my world -- timed exams have always been problematic. In a timed exam we show the slider from the start. Now we are getting double sliders.

Screen Shot 2022-09-08 at 4 56 46 PM
bnmnetp commented 2 years ago

The overview book has a couple of timed exams you can play with.

bnmnetp commented 2 years ago

I see ---

See the timedInit function in TimedActiveCodeMixin where I already have the call await this.addHistoryScrubber(true);

bnmnetp commented 2 years ago

No need for you to do anything... I just removed that call and everything looks good.

I don't think there is any reason to worry about awaiting it when we load the page and are initializing everything. I think I was just doing that for timed exams to be careful.

bnmnetp commented 2 years ago

OK, this will be live on Saturday. We will know a lot by Monday morning.