search

RunestoneInteractive / fopp

Foundations of Python Programming
https://runestone.academy/runestone/static/fopp/index.html
38 stars 120 forks source link

Potential typo in Sec 12.4 Activty 3 ShowEval (eval11_3_1) - indentation error #276

Closed BergProfJ closed 4 years ago

BergProfJ commented 5 years ago

Describe the bug I believe there may be an indentation error (lack of indentation) in Activity 3 ShowEval (eval11_3_1). The activity is designed to lead students through the steps in a function invocation. It appears as if the two statements that are part of the function hello2 aren't properly indented within the function.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://runestone.academy/runestone/books/published/fopp/Functions/FunctionParameters.html.'
  2. Scroll down to 'Activity 3 ShowEval (eval11_3_1)'
  3. See error - incorrect indentation

Expected behavior I believe the 'print' statements should be indented inside function 'hello2'

Screenshots If applicable, add screenshots to help explain your problem. image

Desktop (please complete the following information):

bnmnetp commented 5 years ago

Thanks for this report.

The source is indented, so I'll have to investigate what has changed to see why it is not displaying as indented.

I'm not sure that I like this showEval very much as it seems confusing that the first animation shows a function call resolving to a def, which is not correct. I'll think about it and try to fix it up.

dbrucknr commented 4 years ago

Hey,

It looks like this issue has been fixed. https://runestone.academy/runestone/books/published/fopp/Functions/FunctionParameters.html Shows that the indentation appears correct.

Can we close this issue?