RunestoneInteractive / fopp

Foundations of Python Programming
https://runestone.academy/runestone/static/fopp/index.html
37 stars 120 forks source link

Fixing links (thanks to Willem Pretorius) #318

Closed tnbai closed 4 years ago

tnbai commented 4 years ago

Not sure if this works - referenced other examples

bnmnetp commented 4 years ago

please test it and let me know when you know it works.

tnbai commented 4 years ago

I haven't figured out how to test the links, would you have any advice?

bnmnetp commented 4 years ago

Build the book and click on them.

  1. pip install runestone
  2. from the fopp folder pip build --all serve. This will let you view the book in your browser by running a little test server.
tnbai commented 4 years ago

I was able to successfully run the first command but the second command is giving me ERROR: unknown command "build". I checked that I'm in my fopp directory and have the latest version of pip installed, and I wasn't able to find much related on Google/Slack

bnmnetp commented 4 years ago

Ooops, I should proofread my comments the command is runestone build --all serve. Which if you read the README for Runestone Components you would have seen. 😄

tnbai commented 4 years ago

I can build the textbook now! Very cool. Thanks for your continued help!

bnmnetp commented 4 years ago

Thats great! Just let me know when you have verified that your changes to the links work, and I'll accept the PR.

tnbai commented 4 years ago

The changes in my newest commit work!

bnmnetp commented 4 years ago

Awesome! Thank you for your help.