search

RunestoneInteractive / fopp

Foundations of Python Programming
https://runestone.academy/runestone/static/fopp/index.html
37 stars 120 forks source link

Wrong list of Python keywords #370

Closed kcrisman closed 5 months ago

kcrisman commented 7 months ago

The list of Python keywords in https://github.com/RunestoneInteractive/fopp/blob/master/_sources/SimplePythonData/VariableNamesandKeywords.rst is no longer up to date. Python 3.5 added async and await, as an example; exec was removed at some point in Python 3, I'm not sure when.

I'm happy to make a PR for this fairly trivial change, but I haven't worked with RS very much before, and there seem to be two important branches, so any advice would be helpful before I do that. (I also don't know if this textbook is currently being rewritten in PreTeXT ...)

presnick commented 7 months ago

Hi,

I think you've found the right branch. We will eventually make a move to PreText, I'm sure, but are still making changes to the .rst version at this point.

Please do make a pull request! It's so great to have a community of people who are noticing things like this and offering to fix them rather than just complaining. Really appreciate it!

On Sat, Feb 3, 2024 at 8:23 PM kcrisman @.***> wrote:

The list of Python keywords in https://github.com/RunestoneInteractive/fopp/blob/master/_sources/SimplePythonData/VariableNamesandKeywords.rst is no longer up to date https://docs.python.org/3/reference/lexical_analysis.html#keywords. Python 3.5 added async and await, as an example; exec was removed at some point in Python 3, I'm not sure when.

I'm happy to make a PR for this fairly trivial change, but I haven't worked with RS very much before, and there seem to be two important branches, so any advice would be helpful before I do that. (I also don't know if this textbook is currently being rewritten in PreTeXT ...)

— Reply to this email directly, view it on GitHub https://github.com/RunestoneInteractive/fopp/issues/370, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIG7TUHQ2TXSOLO4DWC7ALYR3PJ5AVCNFSM6AAAAABCYOEIFOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTMNZZGY4DAMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Paul Resnick Michael D. Cohen Collegiate Professor of Information Associate Dean for Research and Innovation Director, Center for Social Media Responsibility University of Michigan School of Information

Administrative Assistant: Jacques Chestnut @.***

kcrisman commented 7 months ago

Okay, hopefully this is right. Please double and triple check it, I don't want to introduce (or remove) keywords erroneously! See #371 and have fun! It's been good using FOPP, though I will admit that I am mostly using previous materials from colleagues (in order to preserve labs and projects) so this time around FOPP is more supplemental/the "reference location".