RunestoneInteractive / rs

A New Monorepo structure for Runestone
Other
41 stars 68 forks source link

Assessments numbered twice #168

Open DaveParillo opened 6 years ago

DaveParillo commented 6 years ago

Of all the assessments in Runestone, only multiple choice appears to number questions correctly.

Also, the default prefix is inconsistent for those that do use numbering. The default is no prefix for multiple choice assessments and Q- for parsons problems and short answer.

bnmnetp commented 6 years ago

I found the source of this. Its easy to fix the duplicates, but this raises some larger questions.

@bjones1 on line 78 of assessbase.py we are putting the qnumber into the content of a directive. It looks like you made this change a year ago in c6e3032e One bad effect of that is that we get duplicated question numbers in parsons problems because parsons was already handling it another way. I would like to make how we handle qnumber consistent but I think our existing template mechanism is better. Do you recall why you did it this way??

Its good to move getNumber into a parent class but not all directives make the same assumptions about their content, which is why using the template string to position the number is a better choice IMHO.