search

RunestoneInteractive / rs

A New Monorepo structure for Runestone
Other
42 stars 69 forks source link

Pass args instead of null #538

Closed DavidCooperWCU closed 1 month ago

DavidCooperWCU commented 2 months ago

This pass through method wasn’t passing necessary args for methods that take arguments. Now it does.

bnmnetp commented 2 months ago

@DavidCooperWCU

What issue or problems does this PR address?

@bhoffman0 could your or Kate take a look at this and let me know what you think?

bhoffman0 commented 2 months ago

I'd like to get @kmcdonnell2 to look at it too, since it's her code. This is discussed more here https://discord.com/channels/1013815439161315348/1283143831067295766/1283874612572065927.

DavidCooperWCU commented 2 months ago

@DavidCooperWCU

What issue or problems does this PR address?

When trying to get method output for instance methods that take arguments, without this fix, the codetesthelper will fail because the arguments are not sent to the method that requires arguments.

bnmnetp commented 2 months ago

OK, this looks pretty innocuous, have you tested it ? Hopefully @kmcdonnell2 can give it a quick spin. Or maybe there is any easy way to test it on replit or something that is documented somewhere?

DavidCooperWCU commented 2 months ago

This is a working test case. Tested on JGrasp, which is why the test class file is not RunestoneTest.java

WorkingExample.zip

kmcdonnell2 commented 2 months ago

Yes, I believe this change works. I was able to do a quick verification on Repl.it. https://replit.com/@kmcdonnell2/testCode

bnmnetp commented 2 months ago

OK, I will merge, and this should be live with the next update to the site. Saturday at the latest.