Rungutan / sentry-fargate-cf-stack

AWS CloudFormation template to launch a highly-available Sentry 20 stack through ECS Fargate at the minimum cost possible
Apache License 2.0
60 stars 16 forks source link

o1.ingest.domain.tld is not created #1

Closed nodomain closed 3 years ago

nodomain commented 3 years ago

Hi,

awesome project. I had to try it immediately.

Unfortunately, the DNS entry for oi1.ingest.domain.tld is missing in Route53. How to fix it?

Thanks Fabian

mariusmitrofan commented 3 years ago

Hi.

2 things you can do for now as a workaround: 1) create that subdomain manually and point it to a sentry relay :) 2) just ignore that completely and modify the Client DSN to simply point directly to sentry relay

What I will do as a fix for this:

Further note: In case you missed this, the sentry relay LB is "internal", just fyi.

nodomain commented 3 years ago

But if the relay LB is internal how should it then receive traffic from the internet? Or am I mixing things up?

mariusmitrofan commented 3 years ago

For security reasons, it was set that why with the downside of being only able to capture data from "inside your network" (aka add a VPC peering from another VPC in which your app resides).

HOWEVER, I guess it would be nice to leave the choice for that to the user :).

I'll make a PR which will fix both:

What do you think ?

nodomain commented 3 years ago

Awesome. This would fit exactly into our use case where we want to ingest react and vue errors from our users.

mariusmitrofan commented 3 years ago

Cool. Should be fixed by tomorrow. It's late here. Will update the thread when done.

Cheers!

mariusmitrofan commented 3 years ago

The PR fixed the following issues @nodomain:

Please pay attention to the added README nodes though: ->

Important note about stack

The Client DSN record that is created by Sentry each and every time you create a new project looks something like this:

https://some_random_public_key_string_here@o1.ingest.${the_sentry_dns_record}/2

So if the parameter value of SentryDnsRecord is sentry.rungutan.com then the DSN would be:

https://some_random_public_key_string_here@o1.ingest.sentry.rungutan.com/2

Why is this important?

Because you need to make sure that your SSL certificate can handle that specific ingest domain as well

The workaround for this (if it's not possible to use the default ingest record) is to relay on the parameter value that you set up for SentryRelayAlternativeDnsRecord.

This means that if for example the value for SentryRelayAlternativeDnsRecord is sentry-relay.rungutan.com, then you would instead use this specific DSN:

https://some_random_public_key_string_here@sentry-relay.rungutan.com/2
nodomain commented 3 years ago

You are awesome.