set default heartbeat to none

Runnable / hermes

Runnable job queuing system interface abstraction for runnable's services

MIT License

3 stars 1 forks source link

set default heartbeat to none #13

Closed rsandor closed 9 years ago

rsandor commented 9 years ago

Added new process.env.RABBITMQ_HEARTBEAT environment config for custom heartbeat durations.

cflynn07 commented 9 years ago

After some thought I think we should set the default to 0/no-timeout (same default as amqplib) and have the implementor specify their desired timeout value in the options argument when initializing hermes

rsandor commented 9 years ago

What makes you believe that 0 is the appropriate timeout for the majority of our applications?

cflynn07 commented 9 years ago

It's just the default of the underlying client that this wraps. And the underlying client is the most popular client for accessing rabbitmq.