Runroom / runroom-packages

Runroom packages for Symfony development
MIT License
5 stars 5 forks source link

[RunroomSortableBehaviorBundle] Add Usage guide on the README #131

Closed dmitryuk closed 2 years ago

dmitryuk commented 2 years ago

Also would be great to hide pull requests tab in https://github.com/Runroom/RunroomSortableBehaviorBundle, because you are a maintainer

codecov[bot] commented 2 years ago

Codecov Report

Merging #131 (5e2e1be) into master (26f9297) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #131      +/-   ##
============================================
- Coverage     99.16%   99.16%   -0.01%     
  Complexity      615      615              
============================================
  Files           159      159              
  Lines          2264     2262       -2     
============================================
- Hits           2245     2243       -2     
  Misses           19       19              
Impacted Files Coverage Δ
...page-bundle/src/Repository/BasicPageRepository.php 100.00% <ø> (ø)
...es-bundle/src/Repository/CookiesPageRepository.php 100.00% <ø> (ø)
...ction-bundle/src/Repository/RedirectRepository.php 100.00% <ø> (ø)
...undle/src/Repository/MetaInformationRepository.php 100.00% <ø> (ø)
...on-bundle/src/Repository/TranslationRepository.php 100.00% <ø> (ø)
...es/user-bundle/src/Command/ActivateUserCommand.php 100.00% <ø> (ø)
.../user-bundle/src/Command/ChangePasswordCommand.php 100.00% <ø> (ø)
...ages/user-bundle/src/Command/CreateUserCommand.php 100.00% <ø> (ø)
.../user-bundle/src/Command/DeactivateUserCommand.php 100.00% <ø> (ø)
...e-behavior-bundle/src/Admin/SortableAdminTrait.php 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jordisala1991 commented 2 years ago

I think it should be ok now. wdyt @dmitryuk ? I have improve a little bit your changes.

jordisala1991 commented 2 years ago

I think it is a good start, Thank you @dmitryuk