search

Runroom / runroom-packages

Runroom packages for Symfony development
MIT License
5 stars 5 forks source link

[RunroomSortableBehaviorBundle] Fix drag and drop get position #142

Closed eshishko closed 1 year ago

eshishko commented 1 year ago

For drag and drop functionallity, from controller could come new position as numeric ($movePosition). In such case getPosition return same position of object and as result nothing is changed. https://github.com/Runroom/RunroomSortableBehaviorBundle/blob/master/src/Action/MoveAction.php#L64

dmitryuk commented 1 year ago

Can you create a test?

eshishko commented 1 year ago

Updated tests

cgarde89 commented 1 year ago

Hi! is it gonna be merged this?

jordisala1991 commented 1 year ago

Hey!, Yes, I can take a look (not now, but soon).

jordisala1991 commented 1 year ago

Thank you @eshishko . Will release soon 0.16.1