RuntimeTools / SwiftMetrics

Swift Application Metrics instruments the Swift runtime for performance monitoring, providing the monitoring data programatically via an API or visually with an Eclipse Client.
https://developer.ibm.com/swift/monitoring-diagnostics/application-metrics-for-swift/
Other
154 stars 50 forks source link

Support Swift v4 in new branch #137

Closed sjanuary closed 7 years ago

mattcolegate commented 7 years ago

Is there no fancy 'Package@swift-4.0.swift' we can use?

sjanuary commented 7 years ago

@mattcolegate That doesn't seem to work any more. The new way if you want to support 3.1 and 4 is to use // swift-tools-version:3.1 and Swift 4 will build your package in compatability mode, but due to our unusual and specific build requirements SwiftMetrics doesn't actually build with Swift 4 in compatability mode even though it seems like it should. https://github.com/apple/swift-evolution/blob/master/proposals/0152-package-manager-tools-version.md is useful reference.

mattcolegate commented 7 years ago

plus ça change, plus c'est la même chose

sjanuary commented 7 years ago

It seems like having a Package@swift-3.1.swift should work for building on Swift 3.1, but it doesn't, I get: error: Package requires minimum Swift tools version 4.0.0. Current Swift tools version is 3.1.0.

sjanuary commented 7 years ago

Raised https://bugs.swift.org/browse/SR-5849 for current test failures (crash due to double free in omr-agentcore on Linux after building on Swift4)