search

RuntimeTools / SwiftMetrics

Swift Application Metrics instruments the Swift runtime for performance monitoring, providing the monitoring data programatically via an API or visually with an Eclipse Client.
https://developer.ibm.com/swift/monitoring-diagnostics/application-metrics-for-swift/
Other
156 stars 50 forks source link

Updated Package.swift for Swift-cfenv to use 5.0.0 #166

Closed KyeMaloy97 closed 6 years ago

KyeMaloy97 commented 6 years ago

This change will resolve an issue where the swift-server generator would loop on resolving dependencies as its updated to use Cloud Environment 5.0.0

christiancompton commented 6 years ago

@sjanuary Would you mind looking this over?

rolivieri commented 6 years ago

@KyeMaloy97 @christiancompton This PR should be opened against the swift4 branch (not the master branch). The master branch in this repo is for Swift 3.1.1.

@sjanuary Any plans on making the master branch the swift 4 branch? I would recommend deprecating the code for Swift 3.1.1 and move to Swift 4. That will simplify your maintenance and development efforts.

KyeMaloy97 commented 6 years ago

I tried switching the base branch from master to swift 4 but the changes went from 1 to 18 so I will have to update it on my machine and push my changes I think.

KyeMaloy97 commented 6 years ago

@sjanuary I will open a new PR for this, I made the changes on the wrong branch! Apologies.

sjanuary commented 6 years ago

@rolivieri - yes it would be good to make the master branch the swift 4 branch going forwards. I will look into that for the next release.