Closed KyeMaloy97 closed 6 years ago
@KyeMaloy97 - so this depends on an upcoming release of Kitura? I'm going to mark as WIP (work in progress) which we do for PRs that aren't ready to be merged.
@sjanuary Pretty much yea, we need Kitura to get a new release before this PR will be ready to merge.
For the SwiftBAMDC testing, I have created a branch and changed the code around to point to the correct versions to ease testing. Please use my own fork of the repo which is here: https://github.com/KyeMaloy97/SwiftMetrics and use the swift4_BAM_Test branch.
It's pointing to a specific Kitura commit instead of a specific release. I tested using branch in a Starter project and it worked for me. Let me know if you have any issues. If you use it as a dependency in a project and that project also uses Kitura, make sure Kitura's dependency in the Package.swift is set out like this:
.package(url: "https://github.com/IBM-Swift/Kitura.git", .revision("b7e4a665aa16400a63c0bb9596ba99c58d950839"))
@KyeMaloy97 please also add yourself to AUTHORS.md as part of this PR
@KyeMaloy97 thanks for making the changes I asked for yesterday. I've just re-organized the branches for SwiftMetrics and master is now the branch for Swift 4, so please could you redo your PR against master?
This got closed automatically when I deleted the swift4 branch
@KyeMaloy97 Mike showed me how to reopen this against a different branch so no need to create a new one
Merging #172 into master will increase coverage by
<.01%
. The diff coverage is1.25%
.
@@ Coverage Diff @@
## master #172 +/- ##
=========================================
+ Coverage 21.5% 21.5% +<.01%
=========================================
Files 11 11
Lines 2572 2571 -1
Branches 69 69
=========================================
Hits 553 553
+ Misses 1994 1993 -1
Partials 25 25
Flag | Coverage Δ | |
---|---|---|
#SwiftBAMDC | 21.5% <1.25%> (ø) |
:arrow_up: |
#SwiftMetrics | 21.5% <1.25%> (ø) |
:arrow_up: |
#SwiftMetricsBluemix | 21.5% <1.25%> (ø) |
:arrow_up: |
#SwiftMetricsDash | 21.5% <1.25%> (ø) |
:arrow_up: |
#SwiftMetricsKitura | 21.5% <1.25%> (ø) |
:arrow_up: |
#SwiftMetricsPrometheus | 21.5% <1.25%> (ø) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
...rces/SwiftMetricsBluemix/SwiftMetricsBluemix.swift | 0% <0%> (ø) |
:arrow_up: |
Sources/SwiftBAMDC/SwiftMetricsBAMConfig.swift | 0% <0%> (ø) |
:arrow_up: |
Sources/SwiftMetrics/SwiftMonitor.swift | 86.52% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 157c51d...23fadac. Read the comment docs.
This PR requires Kitura to be using the newer version of Kitura-Net (2.0) and Kitura WebSocket (1.0). This should come in an upcoming release.