Closed tunniclm closed 6 years ago
Merging #182 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #182 +/- ##
=======================================
Coverage 16.43% 16.43%
=======================================
Files 8 8
Lines 1959 1959
=======================================
Hits 322 322
Misses 1637 1637
Flag | Coverage Δ | |
---|---|---|
#SwiftBAMDC | 0% <ø> (ø) |
:arrow_up: |
#SwiftMetrics | 16.43% <ø> (ø) |
:arrow_up: |
#SwiftMetricsBluemix | 20.32% <ø> (ø) |
:arrow_up: |
#SwiftMetricsDash | 18.24% <ø> (ø) |
:arrow_up: |
#SwiftMetricsKitura | 17.8% <ø> (ø) |
:arrow_up: |
#SwiftMetricsPrometheus | 16.43% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 06a8947...58992d3. Read the comment docs.
@tunniclm looking at the history it seems that upToNextMinor got added by your team anyway in #172 so I'm happy to remove it if that was a mistake. From a SwiftMetrics POV if we can avoid having to release every time Kitura do a minor update then that's a bonus.
Yes, I think it was a mistake to narrow the range to minors (I had a quick word with @KyeMaloy97 and he agreed). The important part of the earlier change was making the minimum version be 2.1.0
which we can still do with the wider range.
The version range of the SwiftMetrics dependency on Kitura got narrowed in to minor and now Kitura
2.2.0
is not resolving properly with SwiftMetrics2.x
.I don't see any reason not to widen the version range, provided the minimum version remains
2.1.0
.