Remove SwiftyJSON - Githubissues

RuntimeTools / SwiftMetrics

Swift Application Metrics instruments the Swift runtime for performance monitoring, providing the monitoring data programatically via an API or visually with an Eclipse Client.

https://developer.ibm.com/swift/monitoring-diagnostics/application-metrics-for-swift/

Other

154 stars 49 forks source link

Remove SwiftyJSON #191

Closed ShihabMehboob closed 5 years ago

ShihabMehboob commented 6 years ago

This aims to replace SwiftyJSON with Codable.

sjanuary commented 6 years ago

@ShihabMehboob could you rebase this PR please? You seem to have some of Jonathan's changes in the diff that have already been merged into master.

Has this been tested on Bluemix to check that the autoscaling agent is still getting the right data from us?

ShihabMehboob commented 6 years ago

The app has been tested on Bluemix/IBM Cloud, and attached to the autoscaling service, displaying data as seen in the screenshot of the dashboard data.

sjanuary commented 6 years ago

@ShihabMehboob have you re-tested on Bluemix after making the changes that Ian asked for? If so I'm happy to get this merged in.

ShihabMehboob commented 6 years ago