search

RuntimeTools / SwiftMetrics

Swift Application Metrics instruments the Swift runtime for performance monitoring, providing the monitoring data programatically via an API or visually with an Eclipse Client.
https://developer.ibm.com/swift/monitoring-diagnostics/application-metrics-for-swift/
Other
154 stars 49 forks source link

Support Swift 5 #214

Closed djones6 closed 5 years ago

djones6 commented 5 years ago

Update Package.swift to tools-version:5.0 so that SwiftMetrics is compiled at Swift 5 language level.

Also updates the CI to test the latest releases from 4.x, and the 5.0 release build, and to only test KITURA_NIO mode with Swift 5, as future releases of Kitura will run on top of Swift-NIO 2, which requires a minimum of Swift 5.

Finally, resolves some compilation warnings relating to changes in Swift 5.

djones6 commented 5 years ago

Hmm, the tests with Kitura-NIO + Swift 5 failed... I moved the testing of Kitura-NIO to the Swift 5 toolchain, but perhaps that was premature. I've just pushed another commit to move the NIO testing back to the 4.2.x toolchain, but that seems to be failing too... @pushkarnk could you investigate?

Also, there's a follow-up PR required once we release Kitura 2.7 + NIO 2, to move the NIO testing to use Swift 5, and also we can get rid of the libressl install.

ianpartridge commented 5 years ago

Closing in favour of #215